Add Coil:*:DX:VariableSpeed as valid AirflowNetwork:Distribution:Component:Coil#10791
Merged
Myoldmopar merged 3 commits intodevelopfrom Nov 8, 2024
Merged
Add Coil:*:DX:VariableSpeed as valid AirflowNetwork:Distribution:Component:Coil#10791Myoldmopar merged 3 commits intodevelopfrom
Coil:*:DX:VariableSpeed as valid AirflowNetwork:Distribution:Component:Coil#10791Myoldmopar merged 3 commits intodevelopfrom
Conversation
lymereJ
added
NewFeature
lymereJ
commented
Oct 31, 2024
Comment on lines
+10623
to
+10642
| } else if (SELECT_CASE_var == "COIL:COOLING:DX:VARIABLESPEED") { | ||
| ValidateComponent( | ||
| m_state, "Coil:Cooling:DX:VariableSpeed", DisSysCompCoilData(i).name, IsNotOK, format(RoutineName) + CurrentModuleObject); | ||
| ++MultiSpeedHPIndicator; | ||
| if (IsNotOK) { | ||
| ErrorsFound = true; | ||
| } else { | ||
| SetDXCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum); | ||
| } | ||
|
|
||
| } else if (SELECT_CASE_var == "COIL:HEATING:DX:VARIABLESPEED") { | ||
| ValidateComponent( | ||
| m_state, "Coil:Heating:DX:VariableSpeed", DisSysCompCoilData(i).name, IsNotOK, format(RoutineName) + CurrentModuleObject); | ||
| ++MultiSpeedHPIndicator; | ||
| if (IsNotOK) { | ||
| ErrorsFound = true; | ||
| } else { | ||
| SetDXCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum); | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Add variable speed coils as a possible coil choice.
lymereJ
commented
Oct 31, 2024
Comment on lines
+2159
to
+2164
| \item | ||
| \hyperref[coilcoolingdxvariablespeed]{Coil:Cooling:DX:VariableSpeed} | ||
| \item | ||
| \hyperref[coilheatingdxmultispeed]{Coil:Heating:DX:MultiSpeed} | ||
| \item | ||
| \hyperref[coilheatingdxvariablespeed]{Coil:Heating:DX:VariableSpeed} |
Collaborator
Author
There was a problem hiding this comment.
Update the documentation.
Myoldmopar
approved these changes
Nov 8, 2024
Member
Myoldmopar
left a comment
Myoldmopar
left a comment
There was a problem hiding this comment.
OK, this makes sense. Just adding them as valid entries, not having to actually modify any simulation code really. 👍
Member
|
Pulled develop in and tested it, all happy. Those 2 Linux results are likely just the random issues we've seen recently on Linux. Merging this. Thanks @lymereJ and @jasondegraw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.